mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shuai Lin <linshuai2...@gmail.com>
Subject Re: Review Request 43718: Added fs::supported() function.
Date Sun, 21 Feb 2016 07:45:15 GMT


> On Feb. 19, 2016, 9:34 a.m., haosdent huang wrote:
> > src/linux/fs.cpp, line 59
> > <https://reviews.apache.org/r/43718/diff/3/?file=1258901#file1258901line59>
> >
> >     `tokens.back()` instead of `tokens[tokens.size() - 1]`?

Good suggestion, updated.


- Shuai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119847
-----------------------------------------------------------


On Feb. 21, 2016, 7:43 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2016, 7:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
>     https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message