mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yongqiao Wang <yq...@cn.ibm.com>
Subject Re: Review Request 41597: Extending allocator interface to support dynamic weights.
Date Fri, 19 Feb 2016 12:58:31 GMT


> On Feb. 19, 2016, 9:36 a.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1068-1070
> > <https://reviews.apache.org/r/41597/diff/54/?file=1241326#file1241326line1068>
> >
> >     Why don't we need to set `rebalance` here?

According to my understanding, A role appears in `quotaRoleSorter` if it has a quota but it
does not means it has one or more registered frameworks, so if there is no framework register
to this role, it does not need to trigger the allocation immediately after changing it's weight.


- Yongqiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/#review119848
-----------------------------------------------------------


On Feb. 14, 2016, 11:37 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41597/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2016, 11:37 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-3943
>     https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extending allocator interface to support dynamic weights.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp e163669c9c4e4c98572968f18987704b60722a79 
>   include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
>   include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
>   src/master/allocator/mesos/allocator.hpp 581eaad376e7b2febe0b6359014617b935a677a3 
>   src/master/allocator/mesos/hierarchical.hpp 20d7ceb1a75ea5cb9efb1fc7fb085265b32864fe

>   src/master/allocator/mesos/hierarchical.cpp a9d2c23162892e22220f97d89a076d2311091d91

>   src/master/allocator/sorter/drf/sorter.hpp 4669149b81de39b4bb921ef7cd6787aa583f6e40

>   src/master/allocator/sorter/drf/sorter.cpp 18797e42a9c2bd20392020237cfae600a5ffe12c

>   src/master/allocator/sorter/sorter.hpp a0a779b81f6d048271f15256b38ff907ae144b83 
>   src/tests/allocator.hpp 206e9ac3a83038a691f7929bdd627042b0f363b0 
> 
> Diff: https://reviews.apache.org/r/41597/diff/
> 
> 
> Testing
> -------
> 
> Make & Make check successfully!
> 
> Test case: https://reviews.apache.org/r/41672/
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message