mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Downes <ian.dow...@gmail.com>
Subject Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly
Date Thu, 18 Feb 2016 19:33:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33174/#review119701
-----------------------------------------------------------




src/slave/containerizer/docker.cpp (line 812)
<https://reviews.apache.org/r/33174/#comment181038>

    Why not call update() here, rather than _update()? It will determine the correct pid,
just launched in launchExecutorContainer().


- Ian Downes


On Dec. 15, 2015, 12:14 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33174/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 12:14 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2617
>     https://issues.apache.org/jira/browse/MESOS-2617
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix for docker containerizer not configuring CFS quotas correctly.
> 
> It would be nice to refactor all this isolation code in a way that can be shared between
all containerizers, as this is basically just copied from the CgroupsCpushareIsolator, but
that's a much bigger undertaking.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e 
> 
> Diff: https://reviews.apache.org/r/33174/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message