mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.
Date Tue, 16 Feb 2016 11:05:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119291
-----------------------------------------------------------




src/tests/fetcher_cache_tests.cpp (line 115)
<https://reviews.apache.org/r/42696/#comment180622>

    Please add a virtual dtr here for completeness, i.e., `virtual ~FetcherCacheTest() = default;`.



src/tests/fetcher_cache_tests.cpp (line 147)
<https://reviews.apache.org/r/42696/#comment180627>

    Maybe something like "Whether to checkpoint frameworks." instead?



src/tests/fetcher_cache_tests.cpp (line 148)
<https://reviews.apache.org/r/42696/#comment180621>

    This should be `const`, i.e., `virtual bool checkpoint() const`.



src/tests/fetcher_cache_tests.cpp (line 199)
<https://reviews.apache.org/r/42696/#comment180625>

    `this->` is redundant, please remove.


- Benjamin Bannier


On Feb. 10, 2016, 1:48 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 1:48 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
>     https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> -------
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [       OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [       OK ] FetcherCacheTest.LocalCached (2524 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [       OK ] FetcherCacheTest.LocalUncached (873 ms)
> [       OK ] FetcherCacheTest.LocalCached (1609 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message