mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.
Date Wed, 10 Feb 2016 13:59:33 GMT


> On Feb. 10, 2016, 1:41 p.m., Szymon Konefal wrote:
> > src/linux/perf.cpp, line 479
> > <https://reviews.apache.org/r/43358/diff/4/?file=1239394#file1239394line479>
> >
> >     Shouldn't we use 'nullptr' instead of NULL?
> 
> Bartek Plotka wrote:
>     +1 IMO `nullptr` sounds like a good choice. All, do you agree with that?

LoL, I remember have a ticket said we should use nullptr instead of NULL. https://issues.apache.org/jira/browse/MESOS-3243


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43358/#review118637
-----------------------------------------------------------


On Feb. 10, 2016, 12:39 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43358/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, Niklas Nielsen, Paul Brett,
Szymon Konefal, and Cong Wang.
> 
> 
> Bugs: MESOS-4595
>     https://issues.apache.org/jira/browse/MESOS-4595
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added dynamic map `extra_events` for all additional perf events which are not specified
explicitly `PerfStatistics`
> TODO in next PRs: Add test and extend description for `--perf_events=` option in Mesos
flags.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43358/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message