mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.
Date Tue, 09 Feb 2016 18:18:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
-----------------------------------------------------------

(Updated Feb. 9, 2016, 6:17 p.m.)


Review request for mesos and Bernd Mathiske.


Changes
-------

Rebase


Bugs: MESOS-4486
    https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
-------

Speed up FetcherCacheTest.Local* test cases.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 6b81bf1ea3d571e8f5fb170076b85223b02efe2c

  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 182ac9cfbacd4535fb355aac6ec38559d786e63a

  3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 692fa483ee8a75dedae5ad0e7d2a4aa70dafa8a3

  3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp ec8e1f7562d5747113631351e6d8ff8989cf0fed

  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 84a2a021859d4e5c8547ad2a509eebda428a8255

  CHANGELOG fc387dc83d919228129ea1ef4ac6c17a8fb55a04 
  Makefile.am 2b43854b0d36e4ee9c24a0c6f67480c697b8684a 
  configure.ac b9a99060fe02f95ee1dca4a28deec200301e320b 
  docs/endpoints/files/browse.json.md 7c7049344980a16978a25431e713fbfe61e1cc5f 
  docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
  docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
  docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
  docs/endpoints/files/download.json.md 77c6b97988c30ddcd71d69da1ffa55a10e871051 
  docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
  docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
  docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
  docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
  docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
  docs/endpoints/master/api/v1/scheduler.md 6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
  docs/endpoints/master/create-volumes.md f167452377787920414e8e1ec7712556dae29a65 
  docs/endpoints/master/destroy-volumes.md a9a12adc017d61f77ddacc26c84daa37657c2355 
  docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
  docs/endpoints/master/frameworks.md bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
  docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
  docs/endpoints/master/machine/down.md 82cce61e2a02f7896e7db351bed7a08138e87768 
  docs/endpoints/master/machine/up.md 5bfd95e0945d82030ee536ee247665c455629a64 
  docs/endpoints/master/maintenance/schedule.md e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
  docs/endpoints/master/maintenance/status.md 17e3eef1c2fac12375892ec125a727a62a4ebfca 
  docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
  docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
  docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
  docs/endpoints/master/reserve.md 6d4dee457b79ffd6db1520ab49c5c3331290510e 
  docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83 
  docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
  docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
  docs/endpoints/master/state-summary.md a6d79f0e5703c3f9118869e287fbb512e86c22c0 
  docs/endpoints/master/state.json.md e13993e12526cba47ea7bd1e6f53acc62305250d 
  docs/endpoints/master/state.md 7571d31bc0d653644fda7c0cfa2fbf3e414314d7 
  docs/endpoints/master/tasks.json.md cb1856f296d7420ce3162a60bf634de0991cdde4 
  docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
  docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
  docs/endpoints/master/unreserve.md 81c72d3253141586d6dbe278a07ce1ff179488c6 
  docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
  docs/endpoints/monitor/statistics.json.md 5ce4fc69aaa4b54541841e58ffa29703363b73e2 
  docs/endpoints/monitor/statistics.md 602104b2484022cfa7f41b04affc106703e6f09f 
  docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
  docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
  docs/endpoints/registrar/registry.md 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
  docs/endpoints/slave/api/v1/executor.md e92df49b0a50e0152e54866e812438c9af63c4e0 
  docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
  docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
  docs/endpoints/slave/state.json.md 10f7a7487c3ab76af7d46c5e7deddf724a3df2c1 
  docs/endpoints/slave/state.md 40df6a810b3fd2cae113959d4f42a0c19afbd5d2 
  docs/endpoints/system/stats.json.md a5fb58f35c602c8b03ed911eb374d26f98449585 
  docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
  site/README.md 78609fb68182338199b4d0ad4c333c8f34274ee5 
  src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
  src/examples/event_call_framework.cpp d07d05d4b1eae5d2286d3fc1fdc32247bc19cada 
  src/examples/test_framework.cpp c9695c4aa20ab8e726ad47b2ebbd3f10777cf828 
  src/examples/test_http_executor.cpp 55a427fb240fdfa018ac70fa3af5a6654cb71979 
  src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
  src/slave/containerizer/containerizer.hpp ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
  src/slave/containerizer/mesos/containerizer.hpp 7aa53f6b25384f72a8bae247f3b75e0f95db18c2

  src/slave/containerizer/mesos/containerizer.cpp b484630dfff1645ebc3511fdeb450df82645038d

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b22b9f6e9ba77d044c91203b76e0a7237315eb34

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 2fc79973524d3776d39d378f22ac694030347c73

  src/slave/http.cpp 523e8dc5d5cc435aaba463a17520237a6c7b192c 
  src/slave/slave.cpp 07f93713b5502da4eb7c29b294e52275764be226 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 
  src/tests/containerizer/filesystem_isolator_tests.cpp bec4966daeb756c3217f52907d36991889b923ce

  src/tests/containerizer/isolator_tests.cpp 52a4957ef9ef2b080e62e74bc9852e7470c8a4d4 
  src/tests/containerizer/launch_tests.cpp e0f934cf93f51316b35f34d34f3d0c5f004565d9 
  src/tests/containerizer/memory_test_helper.cpp 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6

  src/tests/containerizer/mesos_containerizer_tests.cpp 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1

  src/tests/containerizer/ns_tests.cpp 4bf45e970bede713fa4ffce205627b149232fe2b 
  src/tests/containerizer/port_mapping_tests.cpp 3e02835764ca25a99c182a228f5b21332875ef01

  src/tests/containerizer/provisioner_appc_tests.cpp e0aa856de94100c29651f64c8b5a98937f27b35b

  src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c 
  src/tests/event_call_framework_test.sh cddb5208bce29cf84c40ff76aff0163d110a98d1 
  src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6 
  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
  src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e 
  src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
  src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
  src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a 
  src/tests/module_tests.cpp 121d65337bdf29f6049ac44bfd903a1f5ea1a09d 
  src/tests/no_executor_framework_test.sh 4fa154ee52454fe3f56161abaa29e58793e627e3 
  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 
  src/tests/persistent_volume_framework_test.sh 074cdcbc4a738170e84887c1773cd7c118112d58 
  src/tests/script.cpp 36ddf40fc003435f852ca138f66c4f33def1637b 
  src/tests/slave_tests.cpp 0884ee596c36583ecfb898f66614b1f77695de8f 
  src/tests/test_framework_test.sh 617ca5283bd626b535d0f8091bd1d622d175f6d8 
  src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 
  src/tests/utils.hpp 140ebaaae43b03568ec49891635f0660cdfb4c85 
  src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 
  support/atexit.sh a4180bd8a0a285c3852b13b60ad9a4fa0d64b480 
  support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 
  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
  support/hooks/commit-msg 51b22a073cc24ab77fb1c2988b28e8c247dd321c 
  support/release.sh 725bee61175e74d9a53aab9e33df1fa8a1a06361 
  support/tag.sh 3136abe894bbb80754f68ce883c224280f9383de 
  support/vote.sh 04bfc09f94aa8ac9418e77db5e99874a60f6d3de 

Diff: https://reviews.apache.org/r/42696/diff/


Testing
-------

Before apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[       OK ] FetcherCacheTest.LocalUncached (2580 ms)
[       OK ] FetcherCacheTest.LocalCached (2524 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
```


After apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[       OK ] FetcherCacheTest.LocalUncached (873 ms)
[       OK ] FetcherCacheTest.LocalCached (1609 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
```

Also test the recovery test manually:

```
sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message