mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.
Date Mon, 08 Feb 2016 22:24:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/#review118306
-----------------------------------------------------------




src/tests/containerizer.hpp (line 140)
<https://reviews.apache.org/r/41290/#comment179529>

    s/v1Mesos/v1Libraries/ ?



src/tests/containerizer.cpp (line 117)
<https://reviews.apache.org/r/41290/#comment179530>

    kill this.



src/tests/containerizer.cpp (line 164)
<https://reviews.apache.org/r/41290/#comment179531>

    ```
    if (executors.contains(...)) {
      Executor* executor = executors[executorInfo.executor_id()];
      ...
      ...
    } else {
      ...
      ...
    }
    ```


- Vinod Kone


On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41290/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
>     https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously,
the containerizer test class only used to handle the driver interface.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
>   src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 
> 
> Diff: https://reviews.apache.org/r/41290/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message