mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.
Date Sat, 06 Feb 2016 14:26:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43267/#review118143
-----------------------------------------------------------




src/slave/http.cpp (line 402)
<https://reviews.apache.org/r/43267/#comment179393>

    For GUI developer, it's better to export more info when it's recovering, e.g. build_time,
build_date. So I'd like to export agent state in `/state`.



src/tests/slave_tests.cpp (line 1405)
<https://reviews.apache.org/r/43267/#comment179394>

    ```
    driver.stop()
    driver.join()
    ```


- Klaus Ma


On Feb. 6, 2016, 6:46 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43267/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2016, 6:46 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-4066
>     https://issues.apache.org/jira/browse/MESOS-4066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will help operators hitting the /state endpoint by not returning incomplete
> data when slave is still recoverying.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 9167030e77efc7e1d0dc0c6bd800d20ba9c55e3c 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
> 
> Diff: https://reviews.apache.org/r/43267/diff/
> 
> 
> Testing
> -------
> 
> make -j3 check GTEST_FILTER="*StateEndpointUnavailableDuringRecovery*"
> 
> ./bin/mesos-tests.sh --gtest_filter="*StateEndpointUnavailableDuringRecovery*" --gtest_repeat=1000
--gtest_break_on_failure
> 
> ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message