mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.
Date Fri, 05 Feb 2016 14:20:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review118012
-----------------------------------------------------------



1. Besides changing the code, you may also need to update the following doc to describe the
newly introduced env var "LIBPROCESS_MAX_WORKER_THREADS"
https://github.com/apache/mesos/blob/master/docs/configuration.md#libprocess-options
2. Have you test the patch with executor from E2E? For example, start Mesos agent with "LIBPROCESS_MAX_WORKER_THREADS"
in itsĀ "--executor_environment_variables" option, launch a task, and check if the libprocess
worker thread number of the related executor is the expected number.

- Qian Zhang


On Feb. 5, 2016, 11:39 a.m., Maged Michael wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 11:39 a.m.)
> 
> 
> Review request for mesos and Klaus Ma.
> 
> 
> Bugs: MESOS-4353
>     https://issues.apache.org/jira/browse/MESOS-4353
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added env var to set upper bound on number of libprocess worker threads.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp d8a74d7 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> -------
> 
> Passed make check on x86_64 Ubuntu 14.04.
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the LIBPROCESS_MAX_WORKER_THREADS
set to the values "1", "7", "9", "1000", "0", "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04
system. The results were as expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created,
respectively. The last 3 tests generated warnings.
> 
> 
> Thanks,
> 
> Maged Michael
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message