mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Travis Hegner <travis.heg...@gmail.com>
Subject Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker
Date Thu, 04 Feb 2016 21:27:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43093/
-----------------------------------------------------------

(Updated Feb. 4, 2016, 9:27 p.m.)


Review request for mesos, haosdent huang and Kapil Arya.


Changes
-------

Couple of build errors fixed.


Bugs: MESOS-4370
    https://issues.apache.org/jira/browse/MESOS-4370


Repository: mesos


Description
-------

Fixes [MESOS-4370]


Diffs (updated)
-----

  src/docker/docker.cpp b4b8d3e 

Diff: https://reviews.apache.org/r/43093/diff/


Testing
-------

This patch will first query the docker API for the HostConfig.NetworkMode, which is populated
with the network name. (Essentially what was passed in --net <name> to the docker run
command). This name is then used as a key in NetworkSettings.Networks.<name>.IPAddress
to get the IP address that is currently in use by the container.

It appears that even though the docker API has been set up to allow for multiple networks,
our testing has indicated that it's still only applying one network to the container (the
last one via the --net argument on the run line). I can only speculate that the docker API
will change again in the near future, but I can't speculate how, so at least this fixes the
problem as it stands right now.

Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04.


Thanks,

Travis Hegner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message