mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.
Date Wed, 03 Feb 2016 22:55:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/#review117684
-----------------------------------------------------------




src/tests/containerizer.hpp (line 140)
<https://reviews.apache.org/r/41290/#comment178959>

    s/v1callbacks/v1Callbacks/



src/tests/containerizer.hpp (line 144)
<https://reviews.apache.org/r/41290/#comment178960>

    s/v1mesos/v1Mesos/



src/tests/containerizer.cpp (lines 104 - 108)
<https://reviews.apache.org/r/41290/#comment178976>

    move this to #163



src/tests/containerizer.cpp (line 116)
<https://reviews.apache.org/r/41290/#comment178970>

    kill this and just do a contains check below at #164.



src/tests/containerizer.cpp (line 157)
<https://reviews.apache.org/r/41290/#comment178961>

    not yours, but can you fix the indentation here?


- Vinod Kone


On Jan. 22, 2016, 8:32 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41290/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 8:32 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
>     https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously,
the containerizer test class only used to handle the driver interface.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.hpp 25b64dacca65aa0ac49a05a2fbaf526aa0761471 
>   src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 
> 
> Diff: https://reviews.apache.org/r/41290/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message