mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 43131: Modified existing usage of Slave constructor.
Date Wed, 03 Feb 2016 22:02:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/
-----------------------------------------------------------

(Updated Feb. 3, 2016, 10:02 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Explicitly invoke `process::ID::generate` instead of hardcoding the constant.


Bugs: MESOS-4255
    https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
-------

This change adds the argument process ID wherever the `Slave` object is constructed.


Diffs (updated)
-----

  src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f 
  src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f 
  src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 

Diff: https://reviews.apache.org/r/43131/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message