mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shuai Lin <linshuai2...@gmail.com>
Subject Re: Review Request 41787: Speed up SlaveRecoveryTest.*.
Date Wed, 03 Feb 2016 15:59:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review117161
-----------------------------------------------------------




src/tests/slave_recovery_tests.cpp (line 404)
<https://reviews.apache.org/r/41787/#comment178242>

    Should't we use `FUTURE_DISPATCH` to wait for the `Slave::_recover` before calling `Clock:settle()`?
This way we can guarantee the clock would be advanced only after the slave has scheduled the
reregister timeout.
    
    E.g. https://github.com/apache/mesos/blob/9e8be083fbf2a2f3759735defae180417c1cfded/src/tests/slave_recovery_tests.cpp#L1559-L1580


- Shuai Lin


On Jan. 15, 2016, 5:11 a.m., Jian Qiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 5:11 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4158
>     https://issues.apache.org/jira/browse/MESOS-4158
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and
a comment is put.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 
> 
> Diff: https://reviews.apache.org/r/41787/diff/
> 
> 
> Testing
> -------
> 
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
> SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
> SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
> SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message