mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.
Date Mon, 01 Feb 2016 05:22:16 GMT


> On Jan. 31, 2016, 1:43 a.m., Neil Conway wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 173
> > <https://reviews.apache.org/r/43023/diff/1/?file=1227235#file1227235line173>
> >
> >     This seems a little more subtle than is warranted.
> 
> Michael Park wrote:
>     The `i` part perhaps? Is it better if we were to call it `back`?
>     ```
>     *stream_ << buffer << (buffer[back] == '.' ? "0" : "");
>     ```
> 
> Neil Conway wrote:
>     Yeah -- not clear that "i" never points to the NUL character for non-empty strings,
etc. Probably would be clearer without the trinary expression.
> 
> Michael Park wrote:
>     The ternary expression was there from before though, that's not something to be "warranted"
right?
>     Are you ok with this if I were to `s/i/back/`? or is it not sufficient?

I've committed this patch with `s/i/back/`. If this is not sufficient, please let me know
and I'll follow-up in a separate patch.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43023/#review117131
-----------------------------------------------------------


On Feb. 1, 2016, 5:14 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43023/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 5:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4566
>     https://issues.apache.org/jira/browse/MESOS-4566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With this + https://reviews.apache.org/r/43024/, the number of calls to
> `operator new` and `operator delete` were reduced by roughly 1/3.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp f9d72243bcd5ae951ae1837fef0842915ff1e896

> 
> Diff: https://reviews.apache.org/r/43023/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message