Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0CA6718EB1 for ; Thu, 28 Jan 2016 01:44:24 +0000 (UTC) Received: (qmail 12382 invoked by uid 500); 28 Jan 2016 01:44:18 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 12353 invoked by uid 500); 28 Jan 2016 01:44:18 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 12335 invoked by uid 99); 28 Jan 2016 01:44:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jan 2016 01:44:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F3664288A61; Thu, 28 Jan 2016 01:44:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2969872628240317608==" MIME-Version: 1.0 Subject: Re: Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'. From: Joris Van Remoortere To: Jie Yu , Michael Park Cc: Joris Van Remoortere , mesos Date: Thu, 28 Jan 2016 01:44:17 -0000 Message-ID: <20160128014417.12173.6952@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joris Van Remoortere X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42890/ X-Sender: Joris Van Remoortere References: <20160128013443.12172.16006@reviews.apache.org> In-Reply-To: <20160128013443.12172.16006@reviews.apache.org> Reply-To: Joris Van Remoortere X-ReviewRequest-Repository: mesos --===============2969872628240317608== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/ ----------------------------------------------------------- (Updated Jan. 28, 2016, 1:44 a.m.) Review request for mesos, Jie Yu and Michael Park. Bugs: MESOS-4505 https://issues.apache.org/jira/browse/MESOS-4505 Repository: mesos Description ------- Used existing functions to aggregate Scalars in the 'Resources' object. Diffs ----- src/master/allocator/sorter/drf/sorter.cpp 1f39f6d12cb2673ef4b75c3efb23ca5f7dbbf29a Diff: https://reviews.apache.org/r/42890/diff/ Testing ------- valgrind on allocator benchmark: 2x Thanks, Joris Van Remoortere --===============2969872628240317608==--