Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 352D418FAE for ; Wed, 27 Jan 2016 20:29:21 +0000 (UTC) Received: (qmail 12338 invoked by uid 500); 27 Jan 2016 20:29:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 12308 invoked by uid 500); 27 Jan 2016 20:29:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 12293 invoked by uid 99); 27 Jan 2016 20:29:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 20:29:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EBF7A1D9D57; Wed, 27 Jan 2016 20:29:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4729452947288690028==" MIME-Version: 1.0 Subject: Re: Review Request 42662: Added common command utils file. From: Jojy Varghese To: Jie Yu Cc: Jojy Varghese , mesos Date: Wed, 27 Jan 2016 20:29:19 -0000 Message-ID: <20160127202919.12172.89225@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jojy Varghese X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42662/ X-Sender: Jojy Varghese References: <20160126021815.12172.69312@reviews.apache.org> In-Reply-To: <20160126021815.12172.69312@reviews.apache.org> X-ReviewBoard-Diff-For: src/common/command_utils.hpp X-ReviewBoard-Diff-For: src/common/command_utils.cpp X-ReviewBoard-Diff-For: src/tests/common/command_utils_tests.cpp Reply-To: Jojy Varghese X-ReviewRequest-Repository: mesos --===============4729452947288690028== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42662/ ----------------------------------------------------------- (Updated Jan. 27, 2016, 8:29 p.m.) Review request for mesos and Jie Yu. Changes ------- addressed review. Repository: mesos Description ------- This common file is a good place to add common command line utilities like tar, digests(sha256, sha512, etc). Currently this functionality is spread in the code base and this change would enable all those call sites to be replaced with a common code. Diffs (updated) ----- src/CMakeLists.txt 47d0a7c0fe73b9297cd7dde6086b5e6e9e1f9e4e src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f src/common/command_utils.hpp PRE-CREATION src/common/command_utils.cpp PRE-CREATION src/tests/common/command_utils_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/42662/diff/ Testing ------- make check. Thanks, Jojy Varghese --===============4729452947288690028==--