Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============5392763126685522731=="
MIME-Version: 1.0
Subject: Re: Review Request 42786: Exposed the global 'help' process and added
 getter functions to it.
From: Neil Conway <neil.conway@gmail.com>
To: Neil Conway <neil.conway@gmail.com>,
 Ben Mahler <benjamin.mahler@gmail.com>,
 Greg Mann <greg@mesosphere.io>
Cc: Kevin Klues <klueska@gmail.com>, mesos <reviews@mesos.apache.org>
Date: Tue, 26 Jan 2016 20:34:33 -0000
Message-ID: <20160126203433.12172.85291@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Neil Conway <noreply@reviews.apache.org>
References: <20160126074053.25059.11168@reviews.apache.org>
In-Reply-To: <20160126074053.25059.11168@reviews.apache.org>
Reply-To: Neil Conway <neil.conway@gmail.com>

--===============5392763126685522731==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/#review116432
-----------------------------------------------------------


3rdparty/libprocess/include/process/help.hpp (line 111)
<https://reviews.apache.org/r/42786/#comment177446>

    Returning a raw pointer here is unfortunate. I wonder if it would be better to return the map by value (since performance is unlikely to matter for most callers), or else return a `shared_ptr`.


3rdparty/libprocess/src/help.cpp (line 104)
<https://reviews.apache.org/r/42786/#comment177444>

    Should just be `string`, not `std::string`.


- Neil Conway


On Jan. 26, 2016, 7:40 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42786/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, there was no way to extract the help strings from the help
> process once they had been installed into it.  The only way to get at
> them was to visit the http endpoint they were associated with and pull
> it from there.
> 
> This commit adds API calls to the process::Help class to get at these
> strings more easily.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/help.hpp 2e76a6a5b1069abce879374a88cea65036873f1d 
>   3rdparty/libprocess/include/process/process.hpp 1e4126f1082c24debd9d713b490d18f5ed83f0be 
>   3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 
> 
> Diff: https://reviews.apache.org/r/42786/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


--===============5392763126685522731==--