Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AFF2C18F06 for ; Sat, 23 Jan 2016 17:13:30 +0000 (UTC) Received: (qmail 14566 invoked by uid 500); 23 Jan 2016 17:13:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 14532 invoked by uid 500); 23 Jan 2016 17:13:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 14503 invoked by uid 99); 23 Jan 2016 17:13:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Jan 2016 17:13:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E3B871CC3E3; Sat, 23 Jan 2016 17:13:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5153116196876624198==" MIME-Version: 1.0 Subject: Re: Review Request 42474: Multiple Disk: Updated Slave initialize to create DiskInfo paths. From: Jie Yu To: Jie Yu , Michael Park Cc: Joris Van Remoortere , mesos Date: Sat, 23 Jan 2016 17:13:29 -0000 Message-ID: <20160123171329.32314.74418@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42474/ X-Sender: Jie Yu X-ReviewBoard-ShipIt: 1 References: <20160123105113.32314.24587@reviews.apache.org> In-Reply-To: <20160123105113.32314.24587@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============5153116196876624198== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42474/#review115988 ----------------------------------------------------------- Ship it! Ship It! - Jie Yu On Jan. 23, 2016, 10:51 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42474/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2016, 10:51 a.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Bugs: MESOS-4403 > https://issues.apache.org/jira/browse/MESOS-4403 > > > Repository: mesos > > > Description > ------- > > Create disk paths based on 'DiskInfo.Source' if the type is 'PATH' > and the directory does not yet exist. > > > Diffs > ----- > > src/slave/containerizer/containerizer.cpp 5e7e55e2dd4e451bb754a6a888e9683760d95873 > src/slave/slave.cpp 1bd973a9cf4d8b922db9bd2f3df93bad7cc743bb > src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc > > Diff: https://reviews.apache.org/r/42474/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > > --===============5153116196876624198==--