Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C44F5185B7 for ; Fri, 22 Jan 2016 19:16:41 +0000 (UTC) Received: (qmail 81817 invoked by uid 500); 22 Jan 2016 19:16:41 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 81795 invoked by uid 500); 22 Jan 2016 19:16:41 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 81777 invoked by uid 99); 22 Jan 2016 19:16:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jan 2016 19:16:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DD70428303C; Fri, 22 Jan 2016 19:16:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1204149406023811027==" MIME-Version: 1.0 Subject: Re: Review Request 42172: Add documentation for logging and ContainerLogger. From: "Neil Conway" To: "Artem Harutyunyan" , "Benjamin Hindman" , "Neil Conway" Cc: "Joseph Wu" , "mesos" Date: Fri, 22 Jan 2016 19:16:39 -0000 Message-ID: <20160122191639.32038.90291@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Neil Conway" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42172/ X-Sender: "Neil Conway" References: <20160120034123.32039.36772@reviews.apache.org> In-Reply-To: <20160120034123.32039.36772@reviews.apache.org> Reply-To: "Neil Conway" X-ReviewRequest-Repository: mesos --===============1204149406023811027== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/#review115906 ----------------------------------------------------------- Can we also mention the common GLOG configuration options? For example, `GLOG_v`. - Neil Conway On Jan. 20, 2016, 3:41 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42172/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 3:41 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway. > > > Bugs: MESOS-4206 > https://issues.apache.org/jira/browse/MESOS-4206 > > > Repository: mesos > > > Description > ------- > > Moves (and updates) logging flags from configuration.md into the new logging.md. > > Add documentation for the ContainerLogger. > Adds documentation about logging in Master/Agent/Framework and the ContainerLogger. > > > Diffs > ----- > > docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0 > docs/home.md ff797fb050d710283fa7e648515ec75779e58f65 > docs/logging.md PRE-CREATION > docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 > src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f > > Diff: https://reviews.apache.org/r/42172/diff/ > > > Testing > ------- > > Previewed on GitHub and via: > ``` > docker build -t mesos/website support/site-docker > docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website > ``` > > > Thanks, > > Joseph Wu > > --===============1204149406023811027==--