Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6A10518CC1 for ; Tue, 19 Jan 2016 12:03:10 +0000 (UTC) Received: (qmail 93646 invoked by uid 500); 19 Jan 2016 12:03:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 93616 invoked by uid 500); 19 Jan 2016 12:03:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 93599 invoked by uid 99); 19 Jan 2016 12:03:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jan 2016 12:03:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C5D772820EF; Tue, 19 Jan 2016 12:03:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1185495030108943188==" MIME-Version: 1.0 Subject: Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves. From: "Klaus Ma" To: "Joris Van Remoortere" , "Alexander Rukletsov" , "Neil Conway" , "Ben Mahler" Cc: "Klaus Ma" , "Guangya Liu" , "mesos" , "Mesos ReviewBot" Date: Tue, 19 Jan 2016 12:03:08 -0000 Message-ID: <20160119120308.7986.75118@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Klaus Ma" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42289/ X-Sender: "Klaus Ma" References: <20160119111017.7986.58934@reviews.apache.org> In-Reply-To: <20160119111017.7986.58934@reviews.apache.org> Reply-To: "Klaus Ma" X-ReviewRequest-Repository: mesos --===============1185495030108943188== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ ----------------------------------------------------------- (Updated Jan. 19, 2016, 8:03 p.m.) Review request for mesos, Alexander Rukletsov, Ben Mahler, Joris Van Remoortere, and Neil Conway. Changes ------- Address comments Bugs: MESOS-4102 https://issues.apache.org/jira/browse/MESOS-4102 Repository: mesos Description ------- __Phenomenon__: Quota doesn't allocate resources on slave joining. __Root Cause__: Event-triggered allocations do not include all available agents. If we calculate remaining resources in the cluster using the partial view, we may overlook already laid away resources for quota'ed roles and lay away more. Hence we may unnecessarily deprive non-quota'ed frameworks of resources. Refer to AlexR's comments for more detail: https://issues.apache.org/jira/browse/MESOS-4102?focusedCommentId=15048495&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15048495 __Solution/Fix__: Calcuated 'remainingClusterResources' by all activated slaves. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.cpp 48acde69b1a2f305b568a7e322a58708063dd30a src/tests/hierarchical_allocator_tests.cpp 9362dd306497ba01e0f387c3862456cdcac6f863 Diff: https://reviews.apache.org/r/42289/diff/ Testing ------- make make check ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=100 --gtest_shuffle Thanks, Klaus Ma --===============1185495030108943188==--