Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A227F18985 for ; Mon, 18 Jan 2016 08:33:03 +0000 (UTC) Received: (qmail 14912 invoked by uid 500); 18 Jan 2016 08:33:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 14880 invoked by uid 500); 18 Jan 2016 08:33:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 14865 invoked by uid 99); 18 Jan 2016 08:33:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 08:33:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5FE341D2009; Mon, 18 Jan 2016 08:33:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6022143743766280060==" MIME-Version: 1.0 Subject: Re: Review Request 41597: Extending allocator interface to support dynamic weights. From: "Yongqiao Wang" To: "Adam B" , "Neil Conway" , "Qian Zhang" Cc: "Yongqiao Wang" , "Mesos ReviewBot" , "mesos" Date: Mon, 18 Jan 2016 08:33:02 -0000 Message-ID: <20160118083302.32039.27883@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Yongqiao Wang" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41597/ X-Sender: "Yongqiao Wang" References: <20160118083231.32039.54636@reviews.apache.org> In-Reply-To: <20160118083231.32039.54636@reviews.apache.org> Reply-To: "Yongqiao Wang" X-ReviewRequest-Repository: mesos --===============6022143743766280060== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ ----------------------------------------------------------- (Updated Jan. 18, 2016, 8:33 a.m.) Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Bugs: MESOS-3943 https://issues.apache.org/jira/browse/MESOS-3943 Repository: mesos Description (updated) ------- Add the interface in allocator to support updating weight at runtime, and the allocator is invoked to allocate the resources based on the updated weights later. Diffs ----- include/mesos/master/allocator.hpp e163669c9c4e4c98572968f18987704b60722a79 include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd src/master/allocator/mesos/allocator.hpp 581eaad376e7b2febe0b6359014617b935a677a3 src/master/allocator/mesos/hierarchical.hpp 101482156ffc5a4fe3cd60be222bfe609330ec3c src/master/allocator/mesos/hierarchical.cpp 48acde69b1a2f305b568a7e322a58708063dd30a src/master/allocator/sorter/drf/sorter.hpp 050896e8b12cd4097ccd137d5284d6b39b0f06ab src/master/allocator/sorter/drf/sorter.cpp 3a442f121f3a1505513877a5c78458a4b8d0a824 src/master/allocator/sorter/sorter.hpp 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 src/tests/allocator.hpp 206e9ac3a83038a691f7929bdd627042b0f363b0 Diff: https://reviews.apache.org/r/41597/diff/ Testing ------- Make & Make check successfully! Test case: https://reviews.apache.org/r/41672/ Thanks, Yongqiao Wang --===============6022143743766280060==--