Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB22C18323 for ; Wed, 6 Jan 2016 00:28:54 +0000 (UTC) Received: (qmail 70093 invoked by uid 500); 6 Jan 2016 00:28:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 70066 invoked by uid 500); 6 Jan 2016 00:28:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 70047 invoked by uid 99); 6 Jan 2016 00:28:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2016 00:28:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0445929819C; Wed, 6 Jan 2016 00:28:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4501718356298982006==" MIME-Version: 1.0 Subject: Re: Review Request 41935: Added persistent volume HTTP endpoint authorization. From: "Jie Yu" To: "Alexander Rukletsov" , "Jie Yu" , "Jan Schlicht" Cc: "Greg Mann" , "mesos" Date: Wed, 06 Jan 2016 00:28:53 -0000 Message-ID: <20160106002853.26043.12082@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41935/ X-Sender: "Jie Yu" References: <20160105173426.26044.45514@reviews.apache.org> In-Reply-To: <20160105173426.26044.45514@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============4501718356298982006== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41935/#review112975 ----------------------------------------------------------- Ship it! Ship It! - Jie Yu On Jan. 5, 2016, 5:34 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41935/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 5:34 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-3903 > https://issues.apache.org/jira/browse/MESOS-3903 > > > Repository: mesos > > > Description > ------- > > Added persistent volume HTTP endpoint authorization. > > > Diffs > ----- > > src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 > src/tests/persistent_volume_endpoints_tests.cpp c0feedee393b8475fd27b0af9344d306a392893e > > Diff: https://reviews.apache.org/r/41935/diff/ > > > Testing > ------- > > `make check` was used to test. > > New tests were added to the persistent volume endpoint tests which exercise the authorization features in a variety of scenarios. > > > Thanks, > > Greg Mann > > --===============4501718356298982006==--