Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5B4C1819D for ; Tue, 5 Jan 2016 19:05:21 +0000 (UTC) Received: (qmail 59796 invoked by uid 500); 5 Jan 2016 19:05:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 59775 invoked by uid 500); 5 Jan 2016 19:05:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 59757 invoked by uid 99); 5 Jan 2016 19:05:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 19:05:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EEA5A2980C0; Tue, 5 Jan 2016 19:05:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6421074137646811422==" MIME-Version: 1.0 Subject: Re: Review Request 41783: Logger Module: Implement the rotating container logger module. From: "Joseph Wu" To: "Artem Harutyunyan" , "Benjamin Hindman" Cc: "Joseph Wu" , "mesos" , "Timothy Chen" , "Mesos ReviewBot" Date: Tue, 05 Jan 2016 19:05:19 -0000 Message-ID: <20160105190519.26043.79223@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joseph Wu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41783/ X-Sender: "Joseph Wu" References: <20160105022130.26043.20596@reviews.apache.org> In-Reply-To: <20160105022130.26043.20596@reviews.apache.org> Reply-To: "Joseph Wu" X-ReviewRequest-Repository: mesos --===============6421074137646811422== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/ ----------------------------------------------------------- (Updated Jan. 5, 2016, 11:05 a.m.) Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Changes ------- Fix some signed comparisons. Bugs: MESOS-4136 https://issues.apache.org/jira/browse/MESOS-4136 Repository: mesos Description ------- Adds a non-default ContainerLogger that constrains total log size by rotating logs (i.e. renaming the head log file). Diffs (updated) ----- src/slave/container_loggers/rotate.hpp PRE-CREATION src/slave/container_loggers/rotate.cpp PRE-CREATION src/slave/container_loggers/rotating.hpp PRE-CREATION src/slave/container_loggers/rotating.cpp PRE-CREATION Diff: https://reviews.apache.org/r/41783/diff/ Testing ------- make check Thanks, Joseph Wu --===============6421074137646811422==--