Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E4FB318195 for ; Tue, 5 Jan 2016 14:44:47 +0000 (UTC) Received: (qmail 47412 invoked by uid 500); 5 Jan 2016 14:44:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 47385 invoked by uid 500); 5 Jan 2016 14:44:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 47368 invoked by uid 99); 5 Jan 2016 14:44:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 14:44:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5095E297F48; Tue, 5 Jan 2016 14:44:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6698925984771791726==" MIME-Version: 1.0 Subject: Re: Review Request 41879: Removed constructor which uses restricted width. From: "Jan Schlicht" To: "Michael Park" , "Jan Schlicht" Cc: "Benjamin Bannier" , "mesos" Date: Tue, 05 Jan 2016 14:44:46 -0000 Message-ID: <20160105144446.26044.96007@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jan Schlicht" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41879/ X-Sender: "Jan Schlicht" References: <20160105082700.26043.80348@reviews.apache.org> In-Reply-To: <20160105082700.26043.80348@reviews.apache.org> Reply-To: "Jan Schlicht" X-ReviewRequest-Repository: mesos --===============6698925984771791726== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41879/#review112855 ----------------------------------------------------------- Ship it! Ship It! - Jan Schlicht On Jan. 5, 2016, 9:27 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41879/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 9:27 a.m.) > > > Review request for mesos, Michael Park and Jan Schlicht. > > > Bugs: MESOS-4275 > https://issues.apache.org/jira/browse/MESOS-4275 > > > Repository: mesos > > > Description > ------- > > This constructor is not needed as we already provide a constructor which > can construct from a (value, unit) pair. Makes Duration constructors > more uniform. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp dc610e697032f0d5d9c7a6524aeb34984041dec7 > > Diff: https://reviews.apache.org/r/41879/diff/ > > > Testing > ------- > > make check (OS X 10.10.5) > > > Thanks, > > Benjamin Bannier > > --===============6698925984771791726==--