Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 720C818468 for ; Tue, 5 Jan 2016 01:36:10 +0000 (UTC) Received: (qmail 74764 invoked by uid 500); 5 Jan 2016 01:36:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 74741 invoked by uid 500); 5 Jan 2016 01:36:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 74724 invoked by uid 99); 5 Jan 2016 01:36:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 01:36:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E4787297BD9; Tue, 5 Jan 2016 01:36:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3097848106356986929==" MIME-Version: 1.0 Subject: Re: Review Request 41909: Fixed posix filesystem isolator to not allow executors with image. From: "Jie Yu" To: "Jie Yu" Cc: "Timothy Chen" , "mesos" Date: Tue, 05 Jan 2016 01:36:08 -0000 Message-ID: <20160105013608.26044.39083@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41909/ X-Sender: "Jie Yu" References: <20160105010600.26044.30527@reviews.apache.org> In-Reply-To: <20160105010600.26044.30527@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============3097848106356986929== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41909/#review112738 ----------------------------------------------------------- src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 81 - 82) Can you move the comments right above: ``` if (executorInfo.container().mesos().has_image()) { ``` src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 91 - 93) In fact, we don't support executorInfo.container().volumes() at all. Let's disallow that as well: ``` if (!executorInfo.container().volumes().empty()) { return Failure("Volumes in ContainerInfo is not supported"); } ``` - Jie Yu On Jan. 5, 2016, 1:06 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41909/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 1:06 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4290 > https://issues.apache.org/jira/browse/MESOS-4290 > > > Repository: mesos > > > Description > ------- > > Fixed posix filesystem isolator to not allow executors with image. > Note that command tasks with image also creates a volume in the executor info, so this check should handle both command tasks and custom executors. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca > > Diff: https://reviews.apache.org/r/41909/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > > --===============3097848106356986929==--