Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B75218097 for ; Tue, 5 Jan 2016 00:11:46 +0000 (UTC) Received: (qmail 55926 invoked by uid 500); 5 Jan 2016 00:11:46 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 55898 invoked by uid 500); 5 Jan 2016 00:11:46 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 55876 invoked by uid 99); 5 Jan 2016 00:11:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 00:11:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C2D6C297AC4; Tue, 5 Jan 2016 00:11:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7771245304349361301==" MIME-Version: 1.0 Subject: Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`. From: "Alex Clemmer" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Michael Hopcroft" , "Joseph Wu" Cc: "mesos" , "Alex Clemmer" , "Yi Sun" Date: Tue, 05 Jan 2016 00:11:44 -0000 Message-ID: <20160105001144.26043.61578@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alex Clemmer" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39803/ X-Sender: "Alex Clemmer" References: <20160104233028.26044.25826@reviews.apache.org> In-Reply-To: <20160104233028.26044.25826@reviews.apache.org> Reply-To: "Alex Clemmer" X-ReviewRequest-Repository: mesos --===============7771245304349361301== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 4, 2016, 11:30 p.m., Yi Sun wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line 86 > > > > > > We are not calling lstat here. Great catch. This should also not overwrite the error returned from our internal symlink API! It's an artifact from the POSIX code. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review112686 ----------------------------------------------------------- On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39803/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 11:26 p.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented stout/os/stat.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 5b38b9af654d7d1c574f0cc573083b66693ced1d > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd > > Diff: https://reviews.apache.org/r/39803/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > > --===============7771245304349361301==--