Return-Path: 
 <reviews-return-18790-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4650E184A0
	for <apmail-mesos-reviews-archive@minotaur.apache.org>;
 Mon,  4 Jan 2016 09:54:02 +0000 (UTC)
Received: (qmail 82098 invoked by uid 500); 4 Jan 2016 09:54:02 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 82070 invoked by uid 500); 4 Jan 2016 09:54:02 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 82052 invoked by uid 99); 4 Jan 2016 09:54:01 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2016 09:54:01 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 827B729764C;
	Mon,  4 Jan 2016 09:54:00 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============0987955523662392958=="
MIME-Version: 1.0
Subject: Re: Review Request 41509: [libprocess] Cleaned up STL I/O includes.
From: "Michael Park" <mpark@apache.org>
To: "Joris Van Remoortere" <joris.van.remoortere@gmail.com>,
 "Benjamin Bannier" <benjamin.bannier@mesosphere.io>,
 "Michael Park" <mpark@apache.org>
Cc: "Alexander Rukletsov" <rukletsov@gmail.com>,
 "mesos" <reviews@mesos.apache.org>
Date: Mon, 04 Jan 2016 09:54:00 -0000
Message-ID: <20160104095400.26043.49945@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Michael Park" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/41509/
X-Sender: "Michael Park" <noreply@reviews.apache.org>
References: <20151222175316.663.38400@reviews.apache.org>
In-Reply-To: <20151222175316.663.38400@reviews.apache.org>
Reply-To: "Michael Park" <mpark@apache.org>
X-ReviewRequest-Repository: mesos

--===============0987955523662392958==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41509/#review112529
-----------------------------------------------------------

Ship it!


Ship It!

- Michael Park


On Dec. 22, 2015, 5:53 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41509/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 5:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-4183
>     https://issues.apache.org/jira/browse/MESOS-4183
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Where possible move operator<< definitions and functions using streams
> to ".cpp" files and include <iosfwd> in ".hpp"s. Also remove unused
> I/O includes and clean up std:: prefixes.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/address.hpp 79429e904546ebeb993663efb9bd9e212c1dbd63 
>   3rdparty/libprocess/include/process/future.hpp 817fca2ba5352a2c1cea1cb6cf6ecc49821215e4 
>   3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/include/process/pid.hpp b22c160ad0051ea1dac733a39a9f833719dbcb58 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
>   3rdparty/libprocess/src/pid.cpp 1a9cbd1eec6aefbd9a40113ae0f4475a90011b85 
> 
> Diff: https://reviews.apache.org/r/41509/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.10.4.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


--===============0987955523662392958==--