mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 42362: Added persistent volume endpoint test without authentication.
Date Thu, 28 Jan 2016 10:53:26 GMT


> On Jan. 27, 2016, 11:20 p.m., Anand Mazumdar wrote:
> > src/tests/persistent_volume_endpoints_tests.cpp, line 1112
> > <https://reviews.apache.org/r/42362/diff/5/?file=1224265#file1224265line1112>
> >
> >     Nit: Can we omit the part about not setting the authentication headers since
it's self-explanatory. 
> >     
> >     How about just:
> >     
> >     ```
> >     // Try a request to create a volume without authentication headers. Additionally,
authorization is not enabled, so any principal, including `None()`, can create and destroy
volumes.
> >     ```
> >     
> >     What do you think?

I think this comment should prepend the test in some form. It's an important bit that we can't
do authz if authn is disabled (i.e. no "honor system"). Here we just need to drag reader's
attention that there are no authn headers created. How about "Send a create volume request
with absent credentials."?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42362/#review116649
-----------------------------------------------------------


On Jan. 27, 2016, 11:04 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42362/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Kapil Arya, and Neil Conway.
> 
> 
> Bugs: MESOS-4395
>     https://issues.apache.org/jira/browse/MESOS-4395
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added persistent volume endpoint tests with HTTP authentication disabled.
> 
> The persistent volume endpoint tests allow volume creation and destruction when HTTP
authentication is disabled; this patch introduces a test for this scenario: `PersistentVolumeEndpointsTest.NoAuthentication`.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 22e18758ee91a649486725473d9e50fae9d43b01

> 
> Diff: https://reviews.apache.org/r/42362/diff/
> 
> 
> Testing
> -------
> 
> A new test, `PersistentVolumeEndpointsTest.NoAuthentication`, was added to the persistent
volume endpoint tests.
> 
> `make check` was used to test, and the new test was run with `--gtest_repeat=1000 -gtest_break_on_failure=1`.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message