mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 42477: Corrected example in quota user doc.
Date Tue, 26 Jan 2016 15:58:42 GMT


> On Jan. 22, 2016, 4:34 p.m., Bernd Mathiske wrote:
> > docs/quota.md, line 166
> > <https://reviews.apache.org/r/42477/diff/2/?file=1205605#file1205605line166>
> >
> >     Please explain what this seemingly redundant field is doing.
> 
> Guangya Liu wrote:
>     I think this is because the current Quota can only works for unreserved and non revocable
resources. There is indeed a document https://github.com/apache/mesos/blob/master/docs/quota.md
for this, make sense?
> 
> Joerg Schad wrote:
>     We use the default Resource protobuf message which includes an optional default field
 
>     ```optional string role = 6 [default = "*"];``` (https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L563).
Note this is the status endpoint, i.e. this field is not used to specify quota.

I agree with Bernd that printing out this field is misleading. Why we do so in the first place?
Because that's how JSON is rendered from protobuf by default. Is this is a good reason not
to care about it? Probably not. Moreover, we have a family of `model()` functions that specify
how certain protobufs should be rendered in JSON (including `Resource`).

I think we can fix the current issue (this patch documents what is actually being returned)
and file a separate ticket for more consistent rendering of `QuotaStatus`. Does it sound right,
fellas?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42477/#review115854
-----------------------------------------------------------


On Jan. 22, 2016, 3:43 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42477/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 3:43 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
> 
> Diff: https://reviews.apache.org/r/42477/diff/
> 
> 
> Testing
> -------
> 
> None: Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message