mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Chen <tnac...@apache.org>
Subject Re: Review Request 42674: Replaced busybox with alpine in docker tests.
Date Sat, 23 Jan 2016 01:26:35 GMT


> On Jan. 23, 2016, 12:14 a.m., Isabel Jimenez wrote:
> > src/tests/health_check_tests.cpp, line 351
> > <https://reviews.apache.org/r/42674/diff/1/?file=1218661#file1218661line351>
> >
> >     Why can't we be consistent and use the official alpine image here too?

Sorry that was a mistake.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115956
-----------------------------------------------------------


On Jan. 23, 2016, 12:02 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755),
which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397

>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message