mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 42181: Added a Slave constructor to pass process ID manually.
Date Fri, 22 Jan 2016 20:27:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42181/
-----------------------------------------------------------

(Updated Jan. 22, 2016, 8:27 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Updated Depends On


Bugs: MESOS-4255
    https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
-------

This change adds a constructor to Slave that takes in the process ID string as an argument.
This is necessary for testing recovery of HTTP based executors. (Previously, every invocation
of `StartSlave` used to generate a new ID via `ID::generate`). There was no process delegate
set via `process::initialize` that led to problems for the existing HTTP based executor to
connect back to the slave.

Also, modified the tests to introduce a new `StartSlave` function that takes this process
ID as argument.


Diffs
-----

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/tests/cluster.hpp 576dcb8b7e27d1905425aa0f7cb319c19c17c15c 
  src/tests/cluster.cpp 1a3a038e78999bca2fc3f08725f4ffaf4290bcb9 
  src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 

Diff: https://reviews.apache.org/r/42181/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message