mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 41789: Expose the http::internal::request function.
Date Wed, 20 Jan 2016 08:45:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/#review115381
-----------------------------------------------------------

Ship it!


Looks great! I'll commit this tomorrow if I don't hear any objection from Joris (the original
shepherd of MESOS-3763).


3rdparty/libprocess/include/process/http.hpp (lines 830 - 831)
<https://reviews.apache.org/r/41789/#comment176369>

    s/Clean/Refactor/
    s/and using/to use/


- Adam B


On Jan. 20, 2016, 12:26 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41789/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 12:26 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil Conway, and
Qian Zhang.
> 
> 
> Bugs: MESOS-3763
>     https://issues.apache.org/jira/browse/MESOS-3763
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose the http::internal::request function.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 1d9a944f7b0c559823c8c889d20e942c7d6a7221

>   3rdparty/libprocess/src/http.cpp 762da9a9038fc0a81156b5c03b556084df1bd7e0 
>   3rdparty/libprocess/src/tests/http_tests.cpp c23d0bf1929686cfc42969f39ce046f4794539d4

> 
> Diff: https://reviews.apache.org/r/41789/diff/
> 
> 
> Testing
> -------
> 
> Make & Make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message