mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.
Date Wed, 20 Jan 2016 05:59:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41963/#review115355
-----------------------------------------------------------


Patch looks great!

Reviews applied: [42052, 41779, 41780, 42358, 42374, 41781, 41782, 41783, 41962, 41963]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Jan. 20, 2016, 3:41 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41963/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 3:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Bugs: MESOS-4150
>     https://issues.apache.org/jira/browse/MESOS-4150
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a call to `ContainerLogger::recover` inside each containerizer's `Containerizer::recover`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0 
>   src/slave/containerizer/mesos/containerizer.cpp ba4daf5cc68c9200b27799aaf4772212d9b0aa80

> 
> Diff: https://reviews.apache.org/r/41963/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX & Centos7)
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT*" (Centos7)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message