mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.
Date Tue, 19 Jan 2016 04:31:07 GMT


> On Jan. 12, 2016, 11:22 p.m., Joseph Wu wrote:
> > src/slave/flags.cpp, lines 206-207
> > <https://reviews.apache.org/r/42035/diff/2/?file=1186486#file1186486line206>
> >
> >     This is sort of weird, in that you only see this Windows note on non-Windows
systems :)
> >     
> >     Maybe pull it out into a comment.

Just regrouping on this: it is a bit weird, but these comments are supposed identical to the
markdown document. I put them in the markdown document just because it's nice to have up-to-date
documentation. That said, empirically we know the Stout README doesn't get a lot of traffic
anyway, so I think this really ends up being mostly a technicality, unfortunately.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42035/#review114100
-----------------------------------------------------------


On Jan. 7, 2016, 9:47 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42035/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Jie Yu, and
Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4310
>     https://issues.apache.org/jira/browse/MESOS-4310
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Mesos agent provides a flag, `--[no-]switch_user`, which instructs
> the agent to run tasks as the user who submitted the task instead of the
> user that is running the agent process itself.
> 
> On POSIX, this requires the usual suspects (`su`, `chown`, and `chroot`,
> for example to do things like make sure the correct user owns the
> executor directory, and things like that.
> 
> On Windows, many of these operations have very different semantics. To
> use one example, to `chown` on Windows, you normally have to give
> *permission* for something to `chown` an object, and then that thing
> actually has to use that permission to `chown` it, on its own.
> 
> Clearly a semantic mismatch of this magnitude will require some work to
> formally bridge, and the result is that we will simply disable the
> functionality entirely on the Windows agent until we are prepared to go
> back and support it formally.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
>   src/slave/flags.hpp 6857fde027fd57b4934cb43ddf435d12900e0b87 
>   src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
> 
> Diff: https://reviews.apache.org/r/42035/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message