mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.
Date Mon, 18 Jan 2016 15:27:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42197/#review114988
-----------------------------------------------------------

Ship it!


Worked perfectly fine in my tests. Let's fix the nits and land this :)


src/tests/environment.cpp (line 310)
<https://reviews.apache.org/r/42197/#comment175837>

    Maybe we should rename this towards PerfCPUCyclesFilter?



src/tests/environment.cpp (line 315)
<https://reviews.apache.org/r/42197/#comment175834>

    Its a bit weird that we make this Linux only using #ifdef's while the tests (perf available,
perf offering CPU cycles support) would do that already. 
    
    For reasons of consistency as well as more targeted error messages, I guess its ok.



src/tests/environment.cpp (line 320)
<https://reviews.apache.org/r/42197/#comment175835>

    s/cycles/cpu-cycles/



src/tests/environment.cpp (line 347)
<https://reviews.apache.org/r/42197/#comment175836>

    s/cycles/cpu-cycles/


- Till Toenshoff


On Jan. 15, 2016, 2:38 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42197/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 2:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3082
>     https://issues.apache.org/jira/browse/MESOS-3082
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Virtual machines may not always support 'CPU performance counters'. Tests
> trying to collect to 'cycle' value of 'perf' will fail under these
> circumstances. This will be avoided by disabling these tests if 'perf' hardware
> events are not available.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
> 
> Diff: https://reviews.apache.org/r/42197/diff/
> 
> 
> Testing
> -------
> 
> Running `sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Perf:*ROOT_CGROUPS_Sample:*ROOT_CGROUPS_UserCgroup:*CGROUPS_ROOT_PerfRollForward:*ROOT_Sample"`
> 
> 1) In a Linux VM without 'CPU performance counters': This doesn't run the tests and shows
an error message that 'cycles' is not available, as expected
> 2) In a Linux VM without 'perf': This doesn't run the tests and shows an error message
that 'perf' is not installed, as expected
> 3) On OSX: This doesn't run the tests and shows an error message that 'perf' is not available,
as expected
> 4) On native Linux (i.e. with 'CPU performance counters'): This runs the tests.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message