mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 42314: Allow schemes in HDFS URI fetcher plugin to be configurable.
Date Fri, 15 Jan 2016 02:19:14 GMT


> On Jan. 14, 2016, 11:35 p.m., Timothy Chen wrote:
> > src/uri/fetchers/hadoop.cpp, line 59
> > <https://reviews.apache.org/r/42314/diff/3/?file=1197029#file1197029line59>
> >
> >     This seems unncessary, even if there is duplicate I think we simply just override
the entry when we register the scheme.

Yes, but because we define the interface to `virtual std::set<std::string> schemes()
= 0;` in `../../include/mesos/uri/fetcher.hpp`. I think pass set here is better.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42314/#review114606
-----------------------------------------------------------


On Jan. 14, 2016, 7:09 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42314/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 7:09 p.m.)
> 
> 
> Review request for mesos, Adam B and Jie Yu.
> 
> 
> Bugs: MESOS-4375
>     https://issues.apache.org/jira/browse/MESOS-4375
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow schemes in HDFS URI fetcher plugin to be configurable.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/hadoop.hpp 066568487dd3d219f87d12cd0fc82113d3a2a28e 
>   src/uri/fetchers/hadoop.cpp 69da5b5ad3c4d085d73ffbeca7c146e421b5dbc1 
> 
> Diff: https://reviews.apache.org/r/42314/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message