mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Klues" <klue...@gmail.com>
Subject Re: Review Request 42212: Added unit test for framework/task history flags.
Date Thu, 14 Jan 2016 02:33:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114382
-----------------------------------------------------------


Talking to bmahler offline, we decided to split the current test into two (more isolated)
tests, which test the max_completed_frameworks and max_completed_tasks_per_framework flags
separately.

- Kevin Klues


On Jan. 13, 2016, 11:01 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
>     https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> -------
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message