mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 42216: Fixed gmock warnings in hook tests.
Date Wed, 13 Jan 2016 21:17:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42216/#review114282
-----------------------------------------------------------


Can you include the names of the tests in the commit message?

- Neil Conway


On Jan. 12, 2016, 10:27 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42216/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 10:27 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Neil Conway.
> 
> 
> Bugs: MESOS-4348
>     https://issues.apache.org/jira/browse/MESOS-4348
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We did not have an expectation on the `shutdown` method of the `MockExecutor`. This led
to the gmock warning being emitted in some runs.
> 
> 
> Diffs
> -----
> 
>   src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f 
> 
> Diff: https://reviews.apache.org/r/42216/diff/
> 
> 
> Testing
> -------
> 
> Loop the tests for 1000 times.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message