mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 42059: Updated ContainerLogger to use Subprocess::IO type.
Date Wed, 13 Jan 2016 19:11:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42059/#review114254
-----------------------------------------------------------

Ship it!



src/slave/containerizer/mesos/containerizer.cpp (lines 829 - 832)
<https://reviews.apache.org/r/42059/#comment175057>

    Subprocess::IO out = Subprocess::FD(STDOUT_FILENO);
    Subprocess::IO err = Subprocess::FD(STDERR_FILENO);
    
    if (!local) {
      out = subprocessInfo.out;
      err = subprocessInfo.err;
    }


- Benjamin Hindman


On Jan. 8, 2016, 6:28 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42059/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 6:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update ContainerLogger to use Subprocess::IO type
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp a2362070ead0afcef1e6c2ca784083ddb01ba51a 
>   src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0

> 
> Diff: https://reviews.apache.org/r/42059/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message