mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 42221: Removed references to wDRF from allocator.
Date Wed, 13 Jan 2016 15:13:41 GMT


> On Jan. 13, 2016, 1:52 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1185
> > <https://reviews.apache.org/r/42221/diff/1/?file=1194999#file1194999line1185>
> >
> >     s/framwork/frameworks
> 
> Alexander Rukletsov wrote:
>     Why do you want plural here?
> 
> Guangya Liu wrote:
>     It is just typo, I think that we can fix it here as it does not deserve to file another
jira to fix it, comments?

It may be a grammatical mistake, but definitely not a typo: I put singular here on purpose.
Only a single framework can accept a resource at a time.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114126
-----------------------------------------------------------


On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 11:06 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f

> 
> Diff: https://reviews.apache.org/r/42221/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message