mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.
Date Tue, 12 Jan 2016 22:20:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42086/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 2:20 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van Remoortere.


Changes
-------

Fixed offer validation for unknown offers.  These are considered "regular" offers for the
purpose of validation.


Bugs: MESOS-4301
    https://issues.apache.org/jira/browse/MESOS-4301


Repository: mesos


Description
-------

Adds `validation::offer::inverse::validate` to validate inverse offers along the same lines
as `validation::offer::validate`, except `SlaveId` is not validated for inverse offers.

Fixes and refactors `Master::accept` to allow `ACCEPT` calls that contain both offers and
inverse offers.
Also tweaks `Master::accept` to not print a misleading log line "ACCEPT call used invalid
offers ..." when the call only includes inverse offers.


Diffs (updated)
-----

  include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a 
  src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
  src/master/master.hpp f02d165874fa8023675e545793de699aeecae29b 
  src/master/master.cpp 5268408fc63a28afabc27cba96d3ecb360608a65 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 

Diff: https://reviews.apache.org/r/42086/diff/


Testing
-------

make check

# Ran the following and checked for blank output:
bin/mesos-tests.sh --gtest_filter="*Inverse*Offer*" --verbose 2>&1 /dev/null |  grep
"ACCEPT call used invalid offers"

# Check new test for flakiness:
bin/mesos-tests.sh --gtest_filter="*OffersAndInverseOffers" --gtest_repeat=1500 --gtest_break_on_failure


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message