mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Schlicht" <...@mesosphere.io>
Subject Re: Review Request 41879: Removed constructor which uses restricted width.
Date Tue, 05 Jan 2016 14:44:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41879/#review112855
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Schlicht


On Jan. 5, 2016, 9:27 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41879/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 9:27 a.m.)
> 
> 
> Review request for mesos, Michael Park and Jan Schlicht.
> 
> 
> Bugs: MESOS-4275
>     https://issues.apache.org/jira/browse/MESOS-4275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This constructor is not needed as we already provide a constructor which
> can construct from a (value, unit) pair. Makes Duration constructors
> more uniform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp dc610e697032f0d5d9c7a6524aeb34984041dec7

> 
> Diff: https://reviews.apache.org/r/41879/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message