Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8C59B18407 for ; Tue, 22 Dec 2015 00:49:20 +0000 (UTC) Received: (qmail 33159 invoked by uid 500); 22 Dec 2015 00:49:20 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 33127 invoked by uid 500); 22 Dec 2015 00:49:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 33106 invoked by uid 99); 22 Dec 2015 00:49:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Dec 2015 00:49:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BD3D3295A69; Tue, 22 Dec 2015 00:49:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5462199182955626822==" MIME-Version: 1.0 Subject: Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks. From: "Joseph Wu" To: "Artem Harutyunyan" , "Benjamin Hindman" , "Thomas Rampelberg" , "Cody Maloney" Cc: "Joseph Wu" , "James DeFelice" , "mesos" , "Timothy Chen" Date: Tue, 22 Dec 2015 00:49:19 -0000 Message-ID: <20151222004919.663.59907@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joseph Wu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41002/ X-Sender: "Joseph Wu" References: <20151221003935.663.98971@reviews.apache.org> In-Reply-To: <20151221003935.663.98971@reviews.apache.org> Reply-To: "Joseph Wu" X-ReviewRequest-Repository: mesos --===============5462199182955626822== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/ ----------------------------------------------------------- (Updated Dec. 21, 2015, 4:49 p.m.) Review request for mesos, Benjamin Hindman, Cody Maloney, Artem Harutyunyan, and Thomas Rampelberg. Changes ------- Change the restriction on `IO::PIPE` into a compile-time restriction. Bugs: MESOS-4087 https://issues.apache.org/jira/browse/MESOS-4087 Repository: mesos Description ------- The container logger is an agent module whose job is to take an executor or task's stdout/stderr, and pipe it to some sink. Existing executor and task stdout/stderr are piped into files ("stdout" and "stderr") located in the executor's sandbox directory. This module aims to encompass this default behavior as well as allow more sophisticated logging solutions. Diffs (updated) ----- include/mesos/slave/container_logger.hpp PRE-CREATION Diff: https://reviews.apache.org/r/41002/diff/ Testing ------- This is added to the Makefile later in the review chain. Thanks, Joseph Wu --===============5462199182955626822==--