Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============3057472858016621182=="
MIME-Version: 1.0
Subject: Re: Review Request 40256: [6/7] Fixed handling of multiple offer
 operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
From: "Jie Yu" <yujie.jay@gmail.com>
To: "Jie Yu" <yujie.jay@gmail.com>, "Neil Conway" <neil.conway@gmail.com>,
 "Michael Park" <mpark@apache.org>
Cc: "Greg Mann" <greg@mesosphere.io>, "mesos" <reviews@mesos.apache.org>
Date: Fri, 18 Dec 2015 20:05:40 -0000
Message-ID: <20151218200540.1672.29596@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jie Yu" <noreply@reviews.apache.org>
References: <20151218093826.1672.19566@reviews.apache.org>
In-Reply-To: <20151218093826.1672.19566@reviews.apache.org>
Reply-To: "Jie Yu" <yujie.jay@gmail.com>

--===============3057472858016621182==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/#review111249
-----------------------------------------------------------

Ship it!


src/tests/persistent_volume_tests.cpp (line 99)
<https://reviews.apache.org/r/40256/#comment171351>

    Looks like `MasterFlags` is not needed anymore with implicit roles. Can you do a sweep to remove it in a subsequent patch?


- Jie Yu


On Dec. 18, 2015, 9:38 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40256/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 9:38 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3065
>     https://issues.apache.org/jira/browse/MESOS-3065
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 01b3c13751a5558d5f06edb8f650c8644dc54486 
> 
> Diff: https://reviews.apache.org/r/40256/diff/
> 
> 
> Testing
> -------
> 
> This is the sixth in a chain of 7 patches. This patch was required in order to fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which was broken by the addition of authorization to the `CREATE` and `DESTROY` offer operations. The test was previously both creating and destroying a persistent volume in a single `acceptOffer` message. However, our `validate` method for `DESTROY` offer operations correctly enforces that in order to delete a volume, the volume should be present in the checkpointed resources of the relevant Agent. This is likely not the case if the `CREATE` and `DESTROY` operations are both in the same message.
> 
> `make check` was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


--===============3057472858016621182==--