Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CDCB31820B for ; Fri, 18 Dec 2015 13:44:24 +0000 (UTC) Received: (qmail 94489 invoked by uid 500); 18 Dec 2015 13:44:24 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 94468 invoked by uid 500); 18 Dec 2015 13:44:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 94449 invoked by uid 99); 18 Dec 2015 13:44:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Dec 2015 13:44:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3C8F72951BA; Fri, 18 Dec 2015 13:44:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8305067352754850209==" MIME-Version: 1.0 Subject: Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer. From: "Benjamin Bannier" To: "Till Toenshoff" , "Michael Park" Cc: "Alexander Rukletsov" , "Benjamin Bannier" , "mesos" Date: Fri, 18 Dec 2015 13:44:24 -0000 Message-ID: <20151218134424.1673.84197@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Benjamin Bannier" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41510/ X-Sender: "Benjamin Bannier" References: <20151217143715.1672.11983@reviews.apache.org> In-Reply-To: <20151217143715.1672.11983@reviews.apache.org> Reply-To: "Benjamin Bannier" X-ReviewRequest-Repository: mesos --===============8305067352754850209== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41510/#review111180 ----------------------------------------------------------- Ship it! src/slave/containerizer/external_containerizer.cpp (line 22) Only focussing on I/O related headers, `iomanip` is unused here as well and should be removed. - Benjamin Bannier On Dec. 17, 2015, 2:37 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41510/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 2:37 p.m.) > > > Review request for mesos, Michael Park and Till Toenshoff. > > > Bugs: MESOS-4183 > https://issues.apache.org/jira/browse/MESOS-4183 > > > Repository: mesos > > > Description > ------- > > Remove unused I/O includes, clean up blank lines and include order. > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.hpp a5b4079a8f89c0c144468b42787c6cec78692d63 > src/slave/containerizer/external_containerizer.cpp 04cf31e005c2be8af0f80dbf856bb94b2ab5351a > > Diff: https://reviews.apache.org/r/41510/diff/ > > > Testing > ------- > > make check on Mac OS 10.10.4. > > > Thanks, > > Alexander Rukletsov > > --===============8305067352754850209==--