Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============3702036350796976914=="
MIME-Version: 1.0
Subject: Re: Review Request 40880: Fix flaky
 MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.
From: "Joerg Schad" <joerg@mesosphere.io>
To: "Artem Harutyunyan" <artem@mesosphere.io>,
 "Till Toenshoff" <toenshoff@me.com>, "Bernd Mathiske" <bernd@mesosphere.io>
Cc: "mesos" <reviews@mesos.apache.org>, "Joerg Schad" <joerg@mesosphere.io>,
 "Joseph Wu" <joseph@mesosphere.io>
Date: Fri, 18 Dec 2015 11:38:07 -0000
Message-ID: <20151218113807.1672.55141@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Joerg Schad" <noreply@reviews.apache.org>
References: <20151203190209.1719.50141@reviews.apache.org>
In-Reply-To: <20151203190209.1719.50141@reviews.apache.org>
Reply-To: "Joerg Schad" <joerg@mesosphere.io>

--===============3702036350796976914==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40880/#review111171
-----------------------------------------------------------

Ship it!


Ship It!

- Joerg Schad


On Dec. 3, 2015, 7:02 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40880/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4047
>     https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` has very similar logic for restarting an agent, re-registering the executor, and even getting `ResourceStatistics`.  But `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is stable.
> 
> This patch updates the flaky test's wait-for-agent-recovery logic to match the stable test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_pressure_tests.cpp e18b971c4df26c9b9c103ca73bdad4fd400d6c02 
> 
> Diff: https://reviews.apache.org/r/40880/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 14:
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery*" --gtest_repeat=-1 --gtest_break_on_failure`
> 
> ^ Ran the above until satisfied.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


--===============3702036350796976914==--