Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============3702321958890874572=="
MIME-Version: 1.0
Subject: Re: Review Request 41380: Added repeated vip field to DiscoveryInfo
 and an instance_port field to Port
From: "Kevin Klues" <klueska@gmail.com>
To: "Anand Mazumdar" <mazumdar.anand@gmail.com>, "Adam B" <adam@mesosphere.io>
Cc: "Kevin Klues" <klueska@gmail.com>,
 "Avinash sridharan" <avinash@mesosphere.io>,
 "mesos" <reviews@mesos.apache.org>
Date: Thu, 17 Dec 2015 08:37:42 -0000
Message-ID: <20151217083742.1673.40419@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Kevin Klues" <noreply@reviews.apache.org>
References: <20151217033157.19750.95680@reviews.apache.org>
In-Reply-To: <20151217033157.19750.95680@reviews.apache.org>
Reply-To: "Kevin Klues" <klueska@gmail.com>

--===============3702321958890874572==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review110922
-----------------------------------------------------------


This review depends on 41189, but 41189 is somehow marked as "Invite-only", so it is not viewable by the public.  This is causing the jenkins review-bot to fail with:

Verifying review 41381
Dependent review: https://reviews.apache.org/api/review-requests/41380/
Dependent review: https://reviews.apache.org/api/review-requests/41189/
Error handling URL https://reviews.apache.org/api/review-requests/41189/: FORBIDDEN

>From my reading of https://www.reviewboard.org/docs/manual/2.5/admin/configuration/access-control/
My guess is all you need to do is make sure that 41189 has the 'mesos' group added to it. If no group is there, it will likely be treated as "Invite-only" since no public groups are accessible.

- Kevin Klues


On Dec. 17, 2015, 3:31 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41380/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 3:31 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4114
>     https://issues.apache.org/jira/browse/MESOS-4114
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added repeated vip field to DiscoveryInfo and an instance_port field to Port
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 
>   include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 
> 
> Diff: https://reviews.apache.org/r/41380/diff/
> 
> 
> Testing
> -------
> 
> make check, and make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


--===============3702321958890874572==--