Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 425A318735 for ; Tue, 15 Dec 2015 17:20:55 +0000 (UTC) Received: (qmail 82025 invoked by uid 500); 15 Dec 2015 17:20:55 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 82005 invoked by uid 500); 15 Dec 2015 17:20:55 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 81987 invoked by uid 99); 15 Dec 2015 17:20:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2015 17:20:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 56FCE2AE5D8; Tue, 15 Dec 2015 17:20:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6516243370392672839==" MIME-Version: 1.0 Subject: Re: Review Request 41386: Logger Module: Add regression test for docker containerizer logging to sandbox. From: "Joseph Wu" To: "Artem Harutyunyan" , "Benjamin Hindman" Cc: "Timothy Chen" , "Joseph Wu" , "mesos" Date: Tue, 15 Dec 2015 17:20:53 -0000 Message-ID: <20151215172053.19749.73477@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joseph Wu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41386/ X-Sender: "Joseph Wu" References: <20151215040828.31807.38920@reviews.apache.org> In-Reply-To: <20151215040828.31807.38920@reviews.apache.org> Reply-To: "Joseph Wu" X-ReviewRequest-Repository: mesos --===============6516243370392672839== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 14, 2015, 8:08 p.m., Timothy Chen wrote: > > src/tests/container_logger_tests.cpp, line 158 > > > > > > Not against adding more tests, but we already have an identical test in the docker containerizer tests Ah, I did not notice. (`DockerContainerizerTest.ROOT_DOCKER_Logs`, right?) - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41386/#review110399 ----------------------------------------------------------- On Dec. 14, 2015, 6:26 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41386/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 6:26 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4137 > https://issues.apache.org/jira/browse/MESOS-4137 > > > Repository: mesos > > > Description > ------- > > `ContainerLoggerTest.ROOT_DOCKER_DefaultToSandbox` is a regression test which checks the existing logging behavior, in which the docker executor and command task are both logged to the same file in the sandbox. > > > Diffs > ----- > > src/tests/container_logger_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41386/diff/ > > > Testing > ------- > > make check (Centos7) > > > Thanks, > > Joseph Wu > > --===============6516243370392672839==--