mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilbert Song" <songzihao1...@gmail.com>
Subject Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.
Date Thu, 31 Dec 2015 23:13:08 GMT


> On Dec. 30, 2015, 6:41 p.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 1614
> > <https://reviews.apache.org/r/41491/diff/4/?file=1177068#file1177068line1614>
> >
> >     Why change this test?

Because we need to os::write manifest to disk and move it to store directory. We have to make
sure `layId` is identical as "456"(originally we only need `layerid - path` pair for MockPuller),
and two `layerPath` are redundant. We only use the last one.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review112369
-----------------------------------------------------------


On Dec. 31, 2015, 3:06 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2015, 3:06 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp e951c96a7f9c5ff72f6993981e2e3744e3b837f6

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp b2e23d82ea255e1c91d7537a58f86632763d9a56

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 89d06e94bd2255bb4f2dad3fae75c1b3d789611d

>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981

>   src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98

> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message