mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 41657: Added user facing documentation for containerizers.
Date Tue, 29 Dec 2015 09:46:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review112139
-----------------------------------------------------------

Ship it!



docs/containerizer.md (line 9)
<https://reviews.apache.org/r/41657/#comment172469>

    I thought about this a little more (not this is not an issue just an idea so feel free
to ignore), maybe it makes sense to focus on the Motivation (instead of defining what containerizers
are)
    
    How do you feel about the following.
    
    # Motivation
    
    As Mesos is able of running a large number of tasks it needs to ensure the following:
    
    * Isolate tasks ....
    * .....
    * ....
    * ......
    
    In order to achieve this Mesos run tasks in 'containers' which in turn can be controlled
by different containerizers.



docs/containerizer.md (line 12)
<https://reviews.apache.org/r/41657/#comment172470>

    s/a task/ tasks?



docs/containerizer.md (line 16)
<https://reviews.apache.org/r/41657/#comment172474>

    with same environment you mean the tasks environment (e.g., provided by the docker container),
which can then be run across different environments (e.g., dev, production, testing)?
    
    In that case the term 'same environment' seems a little misleading.



docs/containerizer.md (line 18)
<https://reviews.apache.org/r/41657/#comment172467>

    Does this make more sense in the section below where you talk about different containerizer?



docs/containerizer.md (line 70)
<https://reviews.apache.org/r/41657/#comment172471>

    For more details see <link to docker containerizer>?



docs/containerizer.md (line 74)
<https://reviews.apache.org/r/41657/#comment172472>

    Do we have more documentation on this array of isolators?


- Joerg Schad


On Dec. 28, 2015, 8:23 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -----
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> -------
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message